Fix UAST unmarshal for empty strings#256
Merged
carlosms merged 1 commit intosrc-d:masterfrom Oct 5, 2018
Merged
Conversation
carlosms
force-pushed
the
uast-empty-str
branch
from
5d90786 to
43e3bf5
Compare
Contributor
Author
|
Test added, squashed into one commit. |
Contributor
Author
|
I forgot about the export handler :/ |
smola
approved these changes
Oct 5, 2018
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
carlosms
force-pushed
the
uast-empty-str
branch
from
6f9a93f to
9291e08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #255.
For empty strings
UnmarshalUASTdoes not return an error, it returnsnil, nil.