Skip to content

npm install should always include sockets messages#412

Closed
1egoman wants to merge 4 commits intomainfrom
npm-install-sockets-messages
Closed

npm install should always include sockets messages#412
1egoman wants to merge 4 commits intomainfrom
npm-install-sockets-messages

Conversation

@1egoman
Copy link
Copy Markdown
Contributor

@1egoman 1egoman commented Oct 22, 2024

This change includes:

  • Adding socket broadcasts for all npm installs globally in the app
  • Making sure that if a process has a null port to not send that to the client, kill+restart it instead
    • I've noticed even with ben's recent change some situations where a null port makes its way to the client, so I'm hoping this makes that case impossible.
  • Hide the installation toast when a server driven npm install finishes
  • Temporarily disable npm install when starting the app: This is to eliminate possible cases as part of some experimentation
    • This should be undone before this change gets merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant