More robust process handling for apps#418
Merged
benjreinhart merged 4 commits intomainfrom Oct 23, 2024
Merged
Conversation
Contributor
Author
|
Here is one instance of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
errorevent (containing an error with code 'ENOENT') but noexitevent. Since it doesn't emitexit, we don't call theonExithandler and therefore never remove the process from the process map. Subsequent calls to start the server won't work because the process map thinks there's an existing process for the vite server, but that process is dead and never ran. Because it never ran, the port is null and thus we seelocahost:nullas the URL for the dev server.TODO
The following still needs to be addressed but will do so in subsequent PR(s)
npm installshould always include sockets messages #412)