Feature/add app config - #19
Merged
Merged
Conversation
srcdev
commented
Jun 20, 2026
Owner
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds app.config-driven defaults under srcdev.* so consumers can set global behavior/appearance for DisplayDialog, DisplayPrompt, DisplayToast, and AlertContentInner once, while preserving per-instance overrides.
Changes:
- Introduces layer-level
app.configdefaults and NuxtAppConfigInputtype augmentation forsrcdev.*. - Updates the four components to resolve values via explicit prop/config →
app.config→ hardcoded fallback. - Updates repo hygiene/docs (
.gitignore,.claude/skills/*) to document the new configuration surface.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
app/types/app-config.d.ts |
Adds AppConfigInput augmentation for typed srcdev.* defaults. |
app/components/02.molecules/alert-content/AlertContentInner.vue |
Resolves theme/dismiss icons via app.config.srcdev.alertContent. |
app/components/01.atoms/toast/DisplayToast.vue |
Adds app.config.srcdev.displayToast fallbacks into computed appearance/behavior values. |
app/components/01.atoms/prompt/DisplayPrompt.vue |
Implements a resolved computed to apply prop → app.config → fallback resolution. |
app/components/01.atoms/display-dialog/DisplayDialog.vue |
Implements a resolved computed and makes close icon configurable via resolved config. |
app/app.config.ts |
Provides layer default values for all four components under srcdev.*. |
.gitignore |
Ignores Claude session project data (.claude/projects/). |
.claude/skills/index.md |
Adds index entry for AlertContentInner docs. |
.claude/skills/components/display-toast.md |
Documents app.config defaults + resolution chain for DisplayToast. |
.claude/skills/components/display-prompt.md |
Documents app.config defaults + resolution chain for DisplayPrompt. |
.claude/skills/components/display-dialog.md |
Documents app.config defaults + closeIcon behavior for DisplayDialog. |
.claude/skills/components/alert-content-inner.md |
New doc describing global icon configuration via app.config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.