fix(shell): the tab bar meets the edge it is allowed to reach - #38
Merged
Conversation
Below an installed app's web view is a strip of screen iOS paints and no CSS here can reach. It carries the app's own background, so a bar in its own shade ends against it in a visible seam — which is what a raised bar looked like, and why the bottom still read as two things rather than one. The bar takes the same surface as the app now, with a single rule across the top to say it is a bar, so it runs into that strip instead of ending at it. And where the system has already cleared the indicator, the labels go all the way down: nothing between them and the edge of what we are allowed to paint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fredrik, after the measurement landed: "gör färgen samma och lägg ner knapparna så långt som möjligt så att det känns som en integrerad del."
Right, and it follows from what the probe showed. Below an installed app's web view is a strip of screen iOS paints and no CSS here can reach; it carries the app's own background. A bar in its own shade (the
--surface-raisedI gave it two PRs ago) therefore ends against that strip in a visible seam — which is exactly why the bottom still read as two things stacked rather than one surface.So:
html.reserved-by-the-osapplies — an installed iOS app, where the system already cleared the indicator — the labels go all the way down:padding-bottom: 0, nothing between them and the edge of what we may paint. Everywhere else keeps its clearance, because there the inset is the only thing holding the bar off the indicator.tests/shell-contract.test.tsupdated to pin the new intent (bar shares the shell surface, keeps a visible top edge, labels on the edge where the system cleared it) — the old assertion pinned the raised surface, which was the seam.npm run verify: 815 passed.🤖 Generated with Claude Code