fix(optimizer): interrupt canceled direct HiGHS solves - #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cancel_requestover a new Unix connection when a sent optimizer request loses its context.Why
#895 stopped stale work in Core, but the Unix sidecar still held its global solve lock until the native solver deadline. A newer plan could therefore wait behind work whose result Core had already discarded.
Scope
Active native interruption applies to direct HiGHS. CVXPY, CLARABEL, and Python model building still stop at their existing checkpoints or deadline; the worker still suppresses their canceled results. The process transport keeps its existing kill-on-cancel path.
Checks
make verify-all: 134 Python tests, all Go packages, Core↔Optimizer contract, Compose migration, full-stack e2e, vet/build, and Linux arm64/amd64 plus Windows amd64 cross-buildsgo test -race ./internal/mpcgit diff --checkPart of #885.