mobile: circular FAB, curved-edge insets, and cursor-paginated ledger - #39
Merged
Conversation
Ship three tester-driven fixes as one closed-track bug-fix update: - FAB: rewrite the add-expense button with explicit inline styles so its shape/color/size/position always land (it was rendering as a tiny centered "+"); enlarge 56->64pt as a proper bottom-right circular FAB. - Screen: honour left/right safe-area insets (default on) so header buttons and the FAB clear the curved glass on curved-edge/notched devices; no-op on flat phones. - Ledger: switch from growing-LIMIT offset reads to keyset (cursor) pagination. The on-screen window lives in state and load-more appends one O(page) keyset page instead of re-reading rows 0..N and re-attaching tags for the whole list on every scroll step (the source of the scroll-more-lags-more jank). Reactivity (native useLiveQuery, web onChanged, focus refresh) preserved; listEntries (offset) left intact for stats/backup. - LedgerManager: resolve categories from one query into a memoized Map instead of a synchronous per-row DB read inside renderItem. Add keyset repo tests (pages every row once in unpaged order; id-tiebreak when occurred_on AND created_at collide; filter/soft-delete parity). Sync package-lock version field to 1.1.8. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
CI format:check flagged the new test block. No logic change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
srjn45
added a commit
that referenced
this pull request
Aug 11, 2026
#39 moved the FAB's paint props (background, shape, shadow, glyph colour) from NativeWind classes into the inline Pressable style. On native release builds those inline paint props silently don't render, so the button became invisible-but- tappable. Restore the v1.1.8 implementation: visible styling via className (like <Button>), inline style for layout/press feedback only. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three tester-driven fixes for the closed-testing track, bundled as one bug-fix update (does not reset the 14-day clock).
Changes
FAB.tsx): rewrite the add-expense button with explicit inline styles so its shape/color/size/position always land — it had been rendering as a tiny centered+. Now a proper 64pt indigo circular FAB pinned bottom-right. (Tester: "the add expense button is very small at the bottom.")Screen.tsx): honour left/right safe-area insets (default on) so header buttons and the FAB clear the curved glass on curved-edge / notched / landscape devices; no-op (0) on flat phones. (Tester: "buttons are not easily clickable on curved edge screens.")entriesRepo.ts,LedgerScreen.tsx): replace the growing-LIMIToffset read with keyset pagination. The on-screen window lives in state and load-more appends one O(page) keyset page viaafter = cursor(lastRow)instead of re-reading rows0..Nand re-attaching tags for the whole list on every scroll step — the cause of the scroll-more-lags-more jank. Cursor key is(occurred_on, created_at, id)withidas a strict tiebreak. Reactivity (nativeuseLiveQuery, webonChanged, focus refresh) preserved;listEntries(offset) left intact for stats/backup.LedgerManager.tsx): resolve categories from one query into a memoizedMapinstead of a synchronous per-row SQLite read insiderenderItem.Tests
id-tiebreak whenoccurred_onandcreated_atcollide; filter + soft-delete parity withlistEntries.Verification
Web preview confirmed the new circular FAB, day-grouped rows, and full-window scroll. (Screenshots captured locally, not committed.)
Note: a react-native-web dev-only
<button> cannot contain a nested <button>overlay appears in the web dev build; it comes from pre-existingLedgerRowstructure, not these changes, and does not affect the native Android build.🤖 Generated with Claude Code