This repository was archived by the owner on May 12, 2021. It is now read-only.
Add support for custom ssb path#829
Merged
Merged
Conversation
Contributor
|
This looks pretty good, and I'm tempted to accept as is. The only issue I have is that ssb-config actually has it's own command line parser (minimist via rc which is clever, but I'm not a huge fan of) that that takes the args passed to patchwork and turns them into config automatically. So passing It might be worth having a play around with the built in arg parser and see if you can get it do what you want. If not, I'll merge this! |
1a9f547 to
57dc1fb
Compare
Contributor
Author
|
Nice catch!! It works perfectly. I updated my PR to just not start git-ssb if a custom path was passed in, so it doesn't blow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow stuff like running from a USB stick (#822). I added
commanderas a dependency so other command line options could be added later if the need arises.With this PR, someone could set their shortcut to something like
patchwork --path /custom/pathor evenpatchwork --path .to use the cwd, which should be perfect for portable installs.Since git-ssb doesn't take in configs, I have Patchwork skip starting it up if a custom path was passed in. If git-ssb changes to allow more granular configs, we can take that conditional out.