Tweak reviewing.md #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staltz
commented
Mar 29, 2023
| Does it have a reference implementation? Is it possible to implement the SIP in a reasonable amount of time with current programming paradigms? Is the specification useful enough to understand how an implementation should work? | ||
| - Is it possible to implement the SIP in a reasonable amount of time with current programming paradigms? | ||
| - Is the specification useful enough to understand how an implementation should work? | ||
| - Does the reference implementation match the specification? |
Member
Author
There was a problem hiding this comment.
This line is the only "change" to the rules, but it was implicitly assumed that duh the implementation has to relate to the spec.
mixmix
approved these changes
Mar 30, 2023
mixmix
pushed a commit
that referenced
this pull request
May 10, 2023
mixmix
added a commit
that referenced
this pull request
May 10, 2023
* add ssb-thread-spec * fix "hidden" class * Update 010.md Co-authored-by: André Staltz <andre@staltz.com> * draft tangles SIP * colors + a number for Tangles * add tangles origin * tangle: make all graphs RL * tangles - make arrows consistent * move tangle_origin out, add links * add defn for root/oldest, tip/newest * add notes on multi author pattern * Update 009.md * limit markdown lines to 80 cols * describe multi-author tangle as a template * slight reword * Tweak reviewing.md (#12) * Add CFT's doc to SIP9 (#13) * drop "Thread Forks" from the spec * Update 010.md Co-authored-by: André Staltz <andre@staltz.com> --------- Co-authored-by: André Staltz <andre@staltz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No changes to the rules in REVIEWING.md, just making the text prettier as a list, and a bit of rephrasing.