Add support for client certificate selection.

[dpwood]

Added a LocalCertificateSelectionCallback property to allow a client certificate to be selected.

[sta]

It looks nice.

And, i want to add a little change such as the following:

    ...
    private LocalCertificateSelectionCallback 
                                    _certSelectionCallback;
    ...

    public LocalCertificateSelectionCallback ClientCertificateSelectionCallback {
      get {
        return _certSelectionCallback;
      }

      ...

How about that?

[dpwood]

Sure, I actually prefer that naming.

My choice for "_userCertSelectionCallback" and
"UserCertificateSelectionCallback" was purely based on the name of the
parameter to the SSLStream constructor (userCertificateSelectionCallback).
However, I see that you have already exposed the
userCertificateValidationCallback parameter of SSLStream as
ServerCertificateValidationCallback, so your decision to name this callback
as Client... makes sense.

Thanks,
Dave

On 8 October 2014 08:10, sta notifications@github.com wrote:

It looks nice.

And, i want to add a little change such as the following:

...
private LocalCertificateSelectionCallback
                                _certSelectionCallback;
...

public LocalCertificateSelectionCallback ClientCertificateSelectionCallback {
  get {
    return _certSelectionCallback;
  }

  ...

How about that?

—
Reply to this email directly or view it on GitHub
#80 (comment).

[dpwood]

I've changed the names as suggested.

[sta]

Thx! I will merge this pull request.

And then, i will add a contributor info comment such as the following:

/*
 * Contributors:
 * - dpwood (or Dave) <your email address>
 */

So, could you tell me your email address (or something changes)?

[dpwood]

David Wood dpwood@gmail.com

Many thanks,
Dave