Skip to content

fix: reduce installer bloat - #32

Merged
stabldev merged 2 commits into
mainfrom
fix/installer-size
Jul 13, 2026
Merged

fix: reduce installer bloat#32
stabldev merged 2 commits into
mainfrom
fix/installer-size

Conversation

@stabldev

@stabldev stabldev commented Jul 13, 2026

Copy link
Copy Markdown
Owner

Removes unnecessary WinUI 3 language packs and excludes .msix from the publish output, reducing the installer size by ~50%.

Summary by CodeRabbit

  • Build & Packaging
    • Reduced published package size by excluding unnecessary installer-related files from output.
    • Removed non-English UI resource files from the publish directory to minimize package bloat.
    • Kept English resources intact so the app’s default language remains unaffected.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: df6e99b9-3581-45be-954d-ccae261d7ecf

📥 Commits

Reviewing files that changed from the base of the PR and between 267c148 and df02871.

📒 Files selected for processing (1)
  • DuskControl.csproj
🚧 Files skipped from review as they are similar to previous changes (1)
  • DuskControl.csproj

📝 Walkthrough

Walkthrough

The project expands publish exclusions and adds a post-publish target that removes non-English .mui files while preserving en-us and en-US resources.

Changes

Publish Cleanup

Layer / File(s) Summary
Publish artifact rules
DuskControl.csproj
Adds bump-version.ps1 and *.msix to publish exclusions and removes non-English .mui files after publishing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: reducing installer size by removing unneeded publish artifacts and language packs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/installer-size

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@DuskControl.csproj`:
- Around line 91-92: Update the Exclude patterns on MuiFiles so the en-us and
en-US English resource exclusions match .mui files recursively at any nesting
depth under PublishDir. Keep MuiFiles recursive and preserve MuiFolders behavior
for all non-English resources.
- Around line 92-94: The cleanup logic around MuiFolders and RemoveDir must not
recursively delete publish or culture directories. Replace the parent-directory
removal with deletion limited to the matched .mui files, or restrict directories
to explicitly known culture folders while preserving unrelated publish contents.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dd33f8fd-052d-4264-b194-5c73105b1b78

📥 Commits

Reviewing files that changed from the base of the PR and between 81aa27e and 267c148.

📒 Files selected for processing (1)
  • DuskControl.csproj

Comment thread DuskControl.csproj Outdated
Comment thread DuskControl.csproj Outdated
@stabldev
stabldev merged commit af3a9d3 into main Jul 13, 2026
1 check passed
@stabldev
stabldev deleted the fix/installer-size branch July 13, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant