fix: close two Pass 10 guard gaps and a stale trunk_branch doc claim - #633
Merged
Conversation
The guard globbed scenarios/*/*.y*ml, covering only subdirectory scenarios and none of the root-tier files. A root-tier scenario swallowed by a .gitignore rule (the cascade-* class the guard exists to catch) stayed invisible. Walk the whole scenarios tree so both tiers are checked. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
extractYAMLFences matched only the exact yaml/yml info string, so a Starlight fence like yaml title="cascade.yaml" escaped TestSchema_ValidatesDocsExamples. Match yaml/yml as a whole leading token followed by end-of-string or whitespace, without over-matching yamlfoo or yaml-lint. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
The generated-workflows reference claimed the push trigger reads config.trunk_branch with a default of main. Since trunk_branch became required, it carries no default: a manifest omitting it fails lint. Correct the claim to match the manifest reference and lint behavior. Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
joshua-temple
force-pushed
the
fix/pass10-guard-gaps-and-stale-docs
branch
from
July 18, 2026 08:02
4161d78 to
1008d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three disjoint Pass 10 findings, each in a different file, fixed with mutation/execution proof.
1. gitignore guard missed the root scenario tier (test hardening)
TestScenarios_AreNotGitIgnoredglobbedscenarios/*/*.y*ml, covering the 44 subdirectory scenarios and none of the ~72 root-tier ones. A root-tier scenario swallowed by a.gitignorerule (thecascade-*class this guard shipped to close) stayed invisible.scenarios/hotfix/reds the guard, but an identical ignored probe atscenarios/99-probe.yamlpassed it. After switching to a recursive walk, both tiers red.2. docs-example guard blind to annotated fences (test hardening)
extractYAMLFencesmatched only the exactyaml/ymlinfo string, so a Starlight fenceyaml title="cascade.yaml"escapedTestSchema_ValidatesDocsExamples.ci:block behind a bare```yamlfence reds; behind```yaml title="x"it passed. Now matchesyaml/ymlas a whole leading token followed by end-of-string or whitespace, and does not over-matchyamlfoooryaml-lint.3. stale
trunk_branchdefault claim (docs)reference/generated-workflows.mdstated the push trigger readsconfig.trunk_branch"(defaultmain)". False sincetrunk_branchbecame required.cascade linton a manifest omittingtrunk_branchemits[ERROR] trunk_branch is required;generate-workflowwithtrunk_branch: releasewritesbranches: [release]. Corrected the claim to required, no default. A full docs grep found this as the only stale prose instance.Verification
go build,go test(3453 pass),golangci-lintclean.cascade verify --own-repo: no drift. Changelog guard passes.Not fleet-relevant: test guards plus a docs correction, no generator or release-path behavior change.