fix: propagate matrix strategy block to retry jobs#78
Merged
Conversation
Signed-off-by: Joshua Temple <joshua.temple@stablekernel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a build callback declares
matrix:andretries > 0, the generator'swriteRetryJobwas not emitting astrategy:block. GHA runs the retry jobin a matrix-less context, so every
${{ matrix.<k> }}reference in thereusable workflow's
with:inputs resolves to an empty string.Fix: call
writeStrategyBlockinwriteRetryJobwheninfo.Matrixisnon-nil, exactly mirroring the existing call in
writeCallbackJob. The sameMatrixConfig(dimensions, max-parallel, fail-fast) is propagated to allretry shims for the job.
Non-matrix retry jobs and non-retry matrix jobs are unchanged.
New tests in
internal/generate/matrix_retry_test.go:TestMatrixRetry_RetryJobCarriesStrategy— matrix + retries → strategy on every retry jobTestMatrixRetry_MatrixWithoutRetries— matrix, no retries → no retry job emitted, primary unchangedTestMatrixRetry_RetriesWithoutMatrix— retries, no matrix → retry job present, no strategy blockCloses #65