feat(composer): default blank workspace name to a unique marine-creature#1069
Merged
AmethystLiang merged 1 commit intomainfrom Apr 25, 2026
Merged
feat(composer): default blank workspace name to a unique marine-creature#1069AmethystLiang merged 1 commit intomainfrom
AmethystLiang merged 1 commit intomainfrom
Conversation
Use the existing getSuggestedCreatureName helper as the fallback seed in getWorkspaceSeedName so blank submissions get a distinct, readable name scoped to the selected repo (respecting nestWorkspaces) instead of colliding on the "workspace" literal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user leaves the workspace name field blank in the composer and has no prompt/linked issue/PR to seed from,
getWorkspaceSeedNamedefaults to the literal"workspace". Creating multiple blank workspaces causes collisions on the same name, forcing git to append numeric suffixes (workspace-2,workspace-3, etc.), which is not user-friendly.Solution
Wire
useComposerStateto compute a repo-scoped unique marine-creature name via the existinggetSuggestedCreatureNamehelper and pass it asfallbackNametogetWorkspaceSeedName. This ensures blank submissions get a distinct, readable identifier (e.g., "nautilus", "dolphin") instead of colliding, while respecting thenestWorkspacessetting.Test coverage: Added unit tests for fallback precedence — explicit name still wins over fallback.
Test plan
pnpm typecheckgetWorkspaceSeedNamefallback precedence (2672 tests green)