fix(updater): let RC users upgrade to newer RC *and* stable releases#1104
Merged
fix(updater): let RC users upgrade to newer RC *and* stable releases#1104
Conversation
PR #1053 fixed RC→RC by switching prerelease users to electron-updater's native github provider with allowPrerelease=true. That silently broke RC→stable: GitHubProvider.getLatestVersion() filters the atom feed by channel, so when the running build's channel is "rc" any stable release (channel=null) gets skipped — trapping the user on the RC channel. Fix: keep the generic provider and resolve the newest tag ourselves by parsing GitHub's /releases.atom (any channel, semver-newest strictly > current version). For prerelease users we re-pin the feed to /releases/download/<tag>/ before each check, which handles BOTH the RC→newer-RC case from #1053 and the RC→stable case it broke. Stable users keep the default /releases/latest/download/ feed untouched, and the Shift-click RC opt-in path (enableIncludePrerelease) is unchanged. Co-authored-by: Orca <help@stably.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1053. That PR fixed the RC→RC case by switching prerelease users to electron-updater's native github provider with
allowPrerelease=true— but it silently broke RC→stable:GitHubProvider.getLatestVersion()filters the atom feed by channel.Fix
Keep the generic provider and resolve the newest tag ourselves:
This handles both the RC→newer-RC case from #1053 and the RC→stable case it broke.
Test plan
Notes
Made with Orca 🐋