Fix shutdown clearing active worktree/tab from wrong layer#44
Merged
AmethystLiang merged 1 commit intomainfrom Mar 23, 2026
Merged
Fix shutdown clearing active worktree/tab from wrong layer#44AmethystLiang merged 1 commit intomainfrom
AmethystLiang merged 1 commit intomainfrom
Conversation
Move activeWorktreeId/activeTabId clearing out of shutdownWorktreeTerminals (a terminal-focused store action) and into the UI component that triggers shutdown. The delete flow already handles this independently in worktrees.ts. Also fix pre-existing lint issues and extract terminal helpers to separate file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeWorktreeId/activeTabIdclearing out ofshutdownWorktreeTerminals(a terminal-focused store action) into the UI component (WorktreeContextMenu) that triggers shutdownworktrees.ts, so the store action was doing double duty incorrectlytabIdsvariable fromshutdownWorktreeTerminalsterminal-helpers.tsto stay under max-lines limitTest plan
🤖 Generated with Claude Code