Skip to content

feat(browser): search suggestion in address bar dropdown#893

Merged
Jinwoo-H merged 3 commits intomainfrom
Jinwoo-H/browser-search-suggestions
Apr 21, 2026
Merged

feat(browser): search suggestion in address bar dropdown#893
Jinwoo-H merged 3 commits intomainfrom
Jinwoo-H/browser-search-suggestions

Conversation

@Jinwoo-H
Copy link
Copy Markdown
Contributor

Summary

  • Show a "query — Google Search" suggestion at the top of the address bar dropdown when input looks like a search query (like Chrome/Firefox omnibox)
  • For URL-like inputs (e.g. "github.com"), the search suggestion appears last as a fallback
  • Search icon distinguishes search suggestions from history entries
  • Uses the styled Select component for the search engine settings dropdown (replaces native <select>)

Test plan

  • Type a search query (e.g. "test") in address bar → first suggestion should be "test — Google Search"
  • Press Enter without arrow-keying → should navigate to Google search
  • Type a URL-like input (e.g. "github.com") → history suggestions first, search option last
  • Arrow down through suggestions → search suggestion has magnifying glass icon, history has globe
  • Change search engine in settings → suggestion label updates (e.g. "test — DuckDuckGo Search")

Match real browser behavior: clicking the address bar selects the URL
but doesn't show the history dropdown. The dropdown appears once the
user starts typing and there are matching suggestions.
Show a "[query] — Google Search" suggestion at the top of the address
bar dropdown when the input looks like a search query, matching how
Chrome and Firefox omniboxes work. For URL-like inputs, the search
suggestion appears last as a fallback.

Also uses a search icon (magnifying glass) to visually distinguish
search suggestions from history entries.
@Jinwoo-H Jinwoo-H merged commit 4a90181 into main Apr 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant