Merged
Conversation
m-mohr
requested changes
Jun 30, 2021
Contributor
m-mohr
left a comment
m-mohr
left a comment
There was a problem hiding this comment.
The last PR was closed so quickly that I put my remarks here:
- The table row for nodata is broken
- Could there be cases where a no-data value is a string? Just checking whether we could run into conflicts...
- As there's the nearly finished PR #16, I'd wait with the release until that comes in, too.
Member
Author
|
2 tasks
|
@emmanuelmathot @m-mohr where are we on this? |
Member
Author
|
I requested the review by @m-mohr but I think he is off. |
Contributor
|
Yes, seems good. I'm just too busy right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.1.0 release + update example to STAC 1.0.0
it is a a minor version because we add functionality in a backwards compatible manner