Search bugfixes #13
Search bugfixes #13
Conversation
| WHEN 'ge' THEN '>=' | ||
| WHEN 'gt' THEN '>' | ||
| WHEN 'le' THEN '<=' | ||
| WHEN 'gte' THEN '>' |
There was a problem hiding this comment.
@bitner this will break the pgstac backend of fast-api, no? Because of these operators?
There was a problem hiding this comment.
yes. the backend is pegged to 0.2.4, so will need to update stac-fastapi pgstac with this and change the pin to 0.2.5
There was a problem hiding this comment.
hi @bitner and @lossyrob: I ended up on this PR as I was encountering the date pagination issue - thanks for fixing it! I think the greater than's got mixed up. Should be the following to match the change happening with the less than's:
WHEN 'gt' THEN '>'
WHEN 'gte' THEN '>='Should I open a PR to fix this?
There was a problem hiding this comment.
Yes! Great catch...a PR would be appreciated, thank you!
There was a problem hiding this comment.
@lossyrob, will you make me a collaborator so I can open the PR? Fixed the issue but don't have access. I imagine I may contribute in the future anyhow
There was a problem hiding this comment.
Ah, the best way to make a PR would be to fork the project into your GitHub account, clone that repo (or add your fork as a remote, e.g. git remote add mine git@github.com:/zstatmanweil/pgstac, push the branch to your fork (git push mine my-fix-branch), and then make the PR from their to the main stac-utils/pgstac GitHub repository. Would that work for you? You can make PRs against this project in that way, and also any other open source project even if your not a collaborator.
There was a problem hiding this comment.
Got it - thanks for the explanation. PR opened!
psql -f pgstac.sql#9)