[CMake] Add SUFFIX_SO_VERSION #201
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
reviewed
Jul 2, 2020
| # --- OPTIONS --------------------------------------- | ||
| # ---------------------------------------------------- | ||
| OPTION(INSTALL_DOCUMENTATION "Generate and install the documentation" FALSE) | ||
| OPTION(SUFFIX_SO_VERSION "Suffix library name with its version" OFF) |
Contributor
There was a problem hiding this comment.
We should decide a common naming for all the projects!
Contributor
Author
There was a problem hiding this comment.
I agree.
This is the name used in many stack-of-tasks projects (eg. sot-core, dynamic-graph).
I think this option under this name was added by @florent-lamiraux in stack-of-tasks/dynamic-graph#59, and other related projects got the same option
Contributor
There was a problem hiding this comment.
TAG_LIBRARY_VERSION is for instance used for Pinocchio and related projects.
Contributor
|
Thank you @nim65s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #200