Set the main lib name according to PEP 3149 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI including #56 & this PR is provided here: https://gepgitlab.laas.fr/gsaurel/eigenpy/pipelines/3453 |
jcarpent
approved these changes
Mar 9, 2019
Contributor
|
@nim65s Thanks for this contribution |
nim65s
added a commit
to nim65s/eigenpy
that referenced
this pull request
Jun 4, 2021
This re-apply stack-of-tasks#57, because the main library is linked to boost python, and in case we have a setup with multiple python versions, we want to ensure that the python module will not link to a version of the main library linked to the wrong boost python library. This is a reccuring issue for users who are using Python 3 on Ubuntu 18.04 or 20.04, while they also have ROS, which is stuck to a Python 2 version of eigenpy. eg. stack-of-tasks#230 This was removed in stack-of-tasks#113. Instead of deactivating this feature for everybody because this can raise an issue on Windows (I have no idea what this issue is), this commit reactivate this feature for everybody except Windows users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR implements jrl-umi3218/jrl-cmakemodules#177 for the main library, sot that we will generate:
lib/libeigenpy.so(linked to boost-python 2) andlib/python2.7/site-packages/eigenpy.sofor python 2lib/libeigenpy.cpython-37m-x86_64-linux-gnu.so(linked to boost-python 3) andlib/python3.7/site-packages/eigenpy.sofor python 3 (this obviously depends on the actually used python version / architecture / etc).This should fix the issue raised in #55, ie. allows us to install the python 2 and python 3 libraries side by side in the same prefix.
But to achieve this goal, we should also handle how the other files (includes and .pc) are installed. I will provide a solution later.