Skip to content

Conversation

@nim65s
Copy link
Contributor

@nim65s nim65s commented Mar 9, 2019

Hi,

This PR updates gitlab's CI to use a generated configuration. This allows us to ease the CI configuration without having to make changes in this repository again.

Currently, this gives this result:
https://gepgitlab.laas.fr/gsaurel/eigenpy/pipelines/3452/builds

Builds on 14.04 / 16.04 on python 3 are allowed to fail because of #35.
Some other builds are currently allowed to fail, but as they succeed, the buildfarm will automatically understand that those builds are passing, and therefore they should not be allowed to fail again.

While here, I'm fixing a PYTHONPATH for one test.

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is important to keep the writing mode on the gitlab.ci file.
It would be also nice to add merge commit.

ADD_PYTHON_UNIT_TEST("py-matrix" "unittest/python/test_matrix.py" "unittest")
ADD_PYTHON_UNIT_TEST("py-geometry" "unittest/python/test_geometry.py" "unittest")
ADD_PYTHON_UNIT_TEST("py-switch" "unittest/python/test_switch.py" "unittest")
ADD_PYTHON_UNIT_TEST("py-switch" "unittest/python/test_switch.py" "python/eigenpy")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you have to do that here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I was lazy :)

@nim65s nim65s closed this Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants