Define actionable diagnostic expectations - #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
Stack consumers need portable diagnostics to explain valid replacements without duplicating compiler semantics in each UI. The existing interchange contract carries location and prose but no structured expected values.
実装方法
expectedarray in portable diagnostics, using an empty array when no useful candidate exists.expectedassertions.テスト方法
uvx --from check-jsonschema==0.38.0 check-jsonschema --check-metaschema schemas/*.jsonfind conformance -name expected.diagnostics.json -print0 | xargs -0 uvx --from check-jsonschema==0.38.0 check-jsonschema --schemafile schemas/diagnostic-expectations.schema.jsonuvx --from check-jsonschema==0.38.0 check-jsonschema --schemafile schemas/normalized-ir.schema.json conformance/valid/*/expected.ir.json conformance/formatter/*/expected.ir.jsonpython scripts/validate-compiler-diagnostics.pypython scripts/validate-formatter-fixtures.pyReview 視点 / 懸念点
The required field changes the draft portable diagnostic shape. Human-readable message, help, and related wording remain outside compatibility; only fixtures that include
expectedrequire exact values and ordering.