Skip to content

Add local provider icons to the Playground - #11

Merged
konojunya merged 1 commit into
mainfrom
jj/web-provider-icon-packs
Sep 4, 2026
Merged

Add local provider icons to the Playground#11
konojunya merged 1 commit into
mainfrom
jj/web-provider-icon-packs

Conversation

@konojunya

Copy link
Copy Markdown
Member

Background

@stack-sh/engine 0.4.0 exposes provider-aware check and render APIs. The Playground needs to consume CLI-created provider packs locally, and the public documentation needs to explain the audited AWS, Google Cloud, and Azure catalogs and their offline boundaries.

Implementation Approach

  • Pin the Playground and documentation to the exact @stack-sh/engine 0.4.0 release.
  • Import one processed provider pack from selected manifest.json and SVG files, enforce bounded inputs and HTTPS provenance URLs, and pass the pack through Engine validation before rendering.
  • Show locally selected provider artwork in an accessible catalog, support copy/remove flows, and generate a notice sidecar for SVGs that use provider icons.
  • Keep provider files in the current tab only: no upload, network fetch, persistence, or vendor SVG assets committed to this repository.
  • Document all 18 audited IDs, official source and terms links, CLI and Playground workflows, and offline behavior in English, Japanese, Chinese, and Korean.

Testing Approach

  • npm run format:check
  • npm run lint
  • npm test (18 tests)
  • npm run build (48 documentation pages)
  • npm run cloudflare:check
  • npm audit --offline --audit-level=high
  • Browser QA with real CLI-created AWS, Google Cloud, and Azure packs, including a three-provider SVG, provider notice availability, console errors, and 320/768/1024/1440 px layouts.

Review Perspectives / Points of Concern

  • Vendor artwork is intentionally user-imported and is not redistributed by the website, npm package, WebAssembly module, or native binary. Static documentation lists the catalog and provenance without copying vendor bytes.
  • The Playground accepts an already processed pack, not a raw vendor ZIP; archive verification and SVG sanitization remain owned by the CLI.
  • Rendering is local and makes no server request after the page loads, but the site is not currently a PWA, so a cold start without network access is not guaranteed.
  • Provider packs are session-only and must be selected again after a reload.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
stack-web a8dadf9 Commit Preview URL

Branch Preview URL
Sep 04 2026, 05:44 AM

@konojunya
konojunya merged commit 01688e7 into main Sep 4, 2026
2 checks passed
@konojunya
konojunya deleted the jj/web-provider-icon-packs branch September 4, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant