fix(nifi): Do not require SNI checks #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: This was already done for 2.4.0 in #1265
xeniape
approved these changes
Nov 4, 2025
xeniape
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
NickLarsenNZ
moved this from Development: In Review
to Development: Done
in Stackable Engineering
|
Patch me baby one more one more one more time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already done for 2.4.0 in #1265
Tip
No, this isn't going against agreed upon values. We did have a discussion about setting the Host header check to false, but "secure by default" was the reason for keeping that enabled and documenting how to disable it.