Skip to content

chore: move product versions into product directory in preparation for individual product build workflows#732

Merged
NickLarsenNZ merged 3 commits intomainfrom
chore/split-product-versions
Jul 2, 2024
Merged

chore: move product versions into product directory in preparation for individual product build workflows#732
NickLarsenNZ merged 3 commits intomainfrom
chore/split-product-versions

Conversation

@NickLarsenNZ
Copy link
Copy Markdown
Member

Description

  • Update image-tools to 0.0.8 (to support importing python modules via conf.py)
  • Move each products version list to a file in the product directory, and import it in the main configuration.
    This will allow us to only build the relevant images based on the change paths (future PR).

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
- [ ] Changes are OpenShift compatible
- [ ] All added packages (via microdnf or otherwise) have a comment on why they are added
- [ ] Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
- [ ] All packages should have (if available) signatures/hashes verified
- [ ] Add an entry to the CHANGELOG.md file
- [ ] Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@NickLarsenNZ NickLarsenNZ self-assigned this Jul 2, 2024
Copy link
Copy Markdown
Member

@Maleware Maleware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've compared a few versions with the original conf.py and haven't find any problems yet.

LGTM - thank you!

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue Jul 2, 2024
Merged via the queue into main with commit 6f32c11 Jul 2, 2024
@NickLarsenNZ NickLarsenNZ deleted the chore/split-product-versions branch July 2, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants