Skip to content

logging docs: mention other sinks - #471

Merged
fhennig merged 26 commits into
mainfrom
logging-sinks
Nov 23, 2023
Merged

logging docs: mention other sinks#471
fhennig merged 26 commits into
mainfrom
logging-sinks

Conversation

@fhennig

@fhennig fhennig commented Oct 18, 2023

Copy link
Copy Markdown
Contributor

closes #470
closes #476

Before only OpenSearch was mentioned. Now it is explained that there are different sinks, and all the ones that Vector has available are supported. Elasticsearch and WebHDFS are mentioned.

Also, formatting was updated to have once sentence per line.

updated page preview: https://deploy-preview-471--stackable-docs.netlify.app/home/nightly/concepts/logging

@netlify

netlify Bot commented Oct 18, 2023

Copy link
Copy Markdown

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit ed39252
🔍 Latest deploy log https://app.netlify.com/sites/stackable-docs/deploys/655f254cd17a1b00083f82eb
😎 Deploy Preview https://deploy-preview-471--stackable-docs.netlify.app/home/nightly/tutorials/logging-vector-aggregator
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fhennig
fhennig marked this pull request as ready for review October 18, 2023 13:18
@siegfriedweber
siegfriedweber self-requested a review October 18, 2023 13:46
Comment thread modules/concepts/pages/logging.adoc Outdated
Comment thread modules/concepts/pages/logging.adoc Outdated
fhennig and others added 2 commits October 19, 2023 13:56
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
siegfriedweber
siegfriedweber previously approved these changes Oct 19, 2023
@fhennig

fhennig commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

Actually, maybe we should also fix this: stackabletech/zookeeper-operator#736

the docs now claim that config is always the same, and I'm using zookeeper explicitly as an example ...

@fhennig

fhennig commented Nov 3, 2023

Copy link
Copy Markdown
Contributor Author

TODO: it's fixed, but now it doesn't work with nightly because of a vector restructuring. ZooKeeper also needs to run with a nightly image.

Comment thread modules/concepts/images/logging_architecture.drawio.svg
Comment thread modules/concepts/pages/logging.adoc Outdated
Comment thread modules/tutorials/pages/logging-vector-aggregator.adoc Outdated
Comment thread modules/tutorials/examples/logging-aggregator/main.sh
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
@fhennig

fhennig commented Nov 13, 2023

Copy link
Copy Markdown
Contributor Author

@siegfriedweber everything should be fixed.

But I would wait with merging this for 23.11, so we get the ZK changes released.

Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated
Comment thread modules/tutorials/pages/logging-vector-aggregator.adoc Outdated
Comment thread modules/tutorials/pages/logging-vector-aggregator.adoc Outdated
fhennig and others added 4 commits November 22, 2023 09:06
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>
Comment thread modules/tutorials/examples/logging-aggregator/main.sh Outdated

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhennig
fhennig added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit fd4dd19 Nov 23, 2023
@fhennig
fhennig deleted the logging-sinks branch November 23, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Document how to configure a Vector aggregator logging: Add section on different sinks (OpenSearch, HDFS, Elastic)

2 participants