fix: display icons on local builds - #911
Merged
Merged
Conversation
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Member
Author
That's one of the things mentioned, that are currently broken (due to #890), and that is not addressed by this PR. It needs changes in the release branches, unrelated to this PR (the one-line change would just look sligthly different pre or post this PR). |
NickLarsenNZ
approved these changes
Aug 4, 2026
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
I can't say I understand each of the changes, but it looks fine from my quick check on the preview site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


The following description is provided by Claude:
Problem
Icons were invisible in local builds. Opening a generated page directly from disk showed no
search icon, no footer social icons and no "external link" arrows next to outbound links.
Separately, the link icons on the glossary page are missing on the live site for all released
versions (e.g. /home/stable/reference/glossary/), while nightly is fine.
Cause
Both problems trace back to #890, which replaced the icon font with SVG icons.
The icons now live in a single shared file that each page points at. That pointer is a request
for a second file, and browsers refuse those on pages opened from disk — so in local builds
every icon silently disappeared. Served over HTTP it works, which is why the live site looked
fine and this slipped through review.
The glossary is a different case. Its icon is defined in the page source itself, which is
versioned, so released branches still contain the old icon-font markup. The stylesheet that
made it visible was removed in #890, so those icons now render as nothing.
Approach
The icon definitions are now included directly in every page, and icons refer to them within
the same page. Nothing needs to be fetched, so they work identically whether the site is opened
from disk, served locally, or deployed.
This adds roughly 2.7 kB (compressed) per page. The far larger saving from #890 — dropping
Font Awesome and its web fonts — is unaffected.
Not covered here
The glossary icons remain broken in already-released versions, since the fix is in page source
that those branches don't have. -> This would need separate PRs backporting the change