Skip to content

fix: display icons on local builds - #911

Merged
xeniape merged 1 commit into
mainfrom
fix/fix-icons-for-local-builds
Aug 4, 2026
Merged

fix: display icons on local builds#911
xeniape merged 1 commit into
mainfrom
fix/fix-icons-for-local-builds

Conversation

@xeniape

@xeniape xeniape commented Aug 4, 2026

Copy link
Copy Markdown
Member

The following description is provided by Claude:

Problem

Icons were invisible in local builds. Opening a generated page directly from disk showed no
search icon, no footer social icons and no "external link" arrows next to outbound links.

Separately, the link icons on the glossary page are missing on the live site for all released
versions (e.g. /home/stable/reference/glossary/), while nightly is fine.

Cause

Both problems trace back to #890, which replaced the icon font with SVG icons.

The icons now live in a single shared file that each page points at. That pointer is a request
for a second file, and browsers refuse those on pages opened from disk — so in local builds
every icon silently disappeared. Served over HTTP it works, which is why the live site looked
fine and this slipped through review.

The glossary is a different case. Its icon is defined in the page source itself, which is
versioned, so released branches still contain the old icon-font markup. The stylesheet that
made it visible was removed in #890, so those icons now render as nothing.

Approach

The icon definitions are now included directly in every page, and icons refer to them within
the same page. Nothing needs to be fetched, so they work identically whether the site is opened
from disk, served locally, or deployed.

This adds roughly 2.7 kB (compressed) per page. The far larger saving from #890 — dropping
Font Awesome and its web fonts — is unaffected.

Not covered here

The glossary icons remain broken in already-released versions, since the fix is in page source
that those branches don't have. -> This would need separate PRs backporting the change

@xeniape xeniape self-assigned this Aug 4, 2026
@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for stackable-docs ready!

Name Link
🔨 Latest commit dffdcc7
🔍 Latest deploy log https://app.netlify.com/projects/stackable-docs/deploys/6a71cdad333ca50008ff90de
😎 Deploy Preview https://deploy-preview-911--stackable-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Aug 4, 2026
@xeniape
xeniape requested a review from lfrancke August 4, 2026 11:36
@NickLarsenNZ

NickLarsenNZ commented Aug 4, 2026

Copy link
Copy Markdown
Member

Using the deploy preview, I see it works on nightly, but will it work for the older releases?

Nightly:

image

26.7:

image

@xeniape

xeniape commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

Using the deploy preview, I see it works on nightly, but will it work for the older releases?

That's one of the things mentioned, that are currently broken (due to #890), and that is not addressed by this PR. It needs changes in the release branches, unrelated to this PR (the one-line change would just look sligthly different pre or post this PR).

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 4, 2026

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I understand each of the changes, but it looks fine from my quick check on the preview site.

@xeniape
xeniape added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit 7c25d43 Aug 4, 2026
8 checks passed
@xeniape
xeniape deleted the fix/fix-icons-for-local-builds branch August 4, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants