Skip to content

Conversation

@sbernauer
Copy link
Member

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
# Acceptance
- [ ] Proper release label has been added

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense

@sbernauer sbernauer added this pull request to the merge queue Feb 23, 2024
Merged via the queue into main with commit 0c93fa7 Feb 23, 2024
@sbernauer sbernauer deleted the feat/long-usernames branch February 23, 2024 11:34
@adwk67
Copy link
Member

adwk67 commented Feb 23, 2024

@sbernauer I don't think the HDFS mapper issues calls with long names, but only short ones, so I'm not sure if the groups-for-users will work with what comes from HDFS. Have we tested that?

@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Feb 23, 2024

@adwk67, it looks like it does based on the example payload in the README (hidden in a details block):

image

@adwk67
Copy link
Member

adwk67 commented Feb 23, 2024

@NickLarsenNZ I mean what comes from here: I think that is just the short name: https://github.com/stackabletech/hdfs-utils/blob/main/src/main/java/tech/stackable/hadoop/StackableGroupMapper.java#L73. I'm probably missing something but I don't see where we resolve that against the UGI.

@NickLarsenNZ
Copy link
Member

@adwk67, good point - I didn't consider the Group Mapper code when approving.
@sbernauer, will the Group Mapper code be updated to provide additional context?

@sbernauer
Copy link
Member Author

sbernauer commented Feb 23, 2024

Well that's a pity... public List<String> getGroups(String user) { only seems to give the shortName and not the full name, making it impossible to return the correct groups in this case if I understood correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants