Skip to content

fix: mapper to use fullname where this can be extracted #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adwk67 merged 1 commit into from
Feb 26, 2024
Merged

fix: mapper to use fullname where this can be extracted #6

adwk67 merged 1 commit into from
Feb 26, 2024

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Feb 23, 2024 •
edited
Loading

Description

fix: mapper to use fullname where this can be extracted
also: added google format version.

See #5

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated

# Acceptance
- [ ] Proper release label has been added

@adwk67 adwk67 marked this pull request as ready for review February 23, 2024 16:53
@adwk67 adwk67 self-assigned this Feb 23, 2024
@NickLarsenNZ
Copy link
Member

NickLarsenNZ commented Feb 26, 2024 •
edited
Loading

@adwk67, just working out how to test this (I have seen the testing section in the Readme). I think it is manual at the moment (I thought there were kuttl tests here).
@sbernauer, feel free to drop a hint :)

sbernauer
sbernauer approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!
I've added an explanation in stackabletech/hdfs-operator@90b659e why this is needed

@adwk67 adwk67 added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit e6d2d60 Feb 26, 2024
@adwk67 adwk67 deleted the fix/mapper-use-full-username branch February 26, 2024 13:09
sbernauer added a commit that referenced this pull request Feb 27, 2024
@sbernauer
Revert "use fullname where this can be extracted: add google format v…
53f1077 
…ersion (#6)"

This reverts commit e6d2d60.
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2024
@sbernauer
Revert "use fullname where this can be extracted: add google format v…
a2b7ece 
…ersion (#6)" (#8)

This reverts commit e6d2d60.
sbernauer added a commit that referenced this pull request Feb 27, 2024
@sbernauer
Add google format version
e7036ac 
Extracted out of #6
@sbernauer sbernauer mentioned this pull request Feb 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 27, 2024
@sbernauer
Add google format version (#9)
8135576 
Extracted out of #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@adwk67 adwk67

@NickLarsenNZ NickLarsenNZ

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adwk67 @NickLarsenNZ @sbernauer