[Merged by Bors] - Refactored authentication handling#408
[Merged by Bors] - Refactored authentication handling#408
Conversation
|
|
| with: | ||
| profile: minimal | ||
| toolchain: "1.63.0" | ||
| toolchain: "1.65.0" |
There was a problem hiding this comment.
are there any changes in this PR that require rust 1.65? In the operator-templating changes that we did as preparation for the next release we stayed with 1.63, so it would be good to know if should move to 1.65 (and we should also change it in ubi8-rust-builder).
There was a problem hiding this comment.
I talked to @sbernauer about this and he told me that we already moved to 1.65 in the framework. I'm not 100% sure but I think the new framework version has a new clap version that requires at least 1.64.
There was a problem hiding this comment.
This should come via templating and not be changed manually (it will fail to build if another templating PR is merged).
@adwk67 could we go for rust 1.65.0 or 1.66.1 in templating before the release?
There was a problem hiding this comment.
yes, I suggest we go for 1.65. We can make that change before we roll out the templating changes across all operators on Thursday.
There was a problem hiding this comment.
operator-templating is already on 1.65 stackabletech/operator-templating@8d04aa2
This actually reduces the lag behind upstreaming templating.
IMHO go for it
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
LGTM. Lets wait for a templating PR to bump the rust version.
|
bors merge |
# Description
- seperated `get_volumes` into 3 functions:
- `get_user_and_password_file_paths`
- `get_additional_container_args`
- `add_volumes_and_mounts`
- `get_config` doesn't take `Client` instance anymore
- AuthenticationClass only resolved once, in a seperate function. This is now the only function using the client.
- Use PodBuilder instead of creating a pod from scratch in some places
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
4 participants
Description
get_volumesinto 3 functions:get_user_and_password_file_pathsget_additional_container_argsadd_volumes_and_mountsget_configdoesn't takeClientinstance anymoreReview Checklist
CRD change approved(not applicable: this is a refactoring)(Integration-)Test cases added(not applicable: this is a refactoring)Documentation added(not applicable: this is a refactoring)Once the review is done, comment
bors r+(orbors merge) to merge. Further information