Skip to content

[Merged by Bors] - Refactored authentication handling #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhennig wants to merge 12 commits into from
Closed

[Merged by Bors] - Refactored authentication handling #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a64a7f9
substantial rewrite of authentication.rs
Jan 16, 2023
1b1cbfd
cargo fmt
Jan 16, 2023
c38bfcc
cargo clippy
Jan 16, 2023
f67eb3d
~
Jan 16, 2023
bc18816
Bump toolchain
Jan 16, 2023
85df367
regenerate charts
Jan 16, 2023
ac9612d
LDAP test: change secret name to not match SecretClass
Jan 16, 2023
e3a156e
Updated changelog
Jan 17, 2023
46f158b
Update rust/operator-binary/src/controller.rs
fhennig Jan 17, 2023
30e614d
refactor: use VolumeBuilder in 'build_keystore_volume'
Jan 17, 2023
4fccb57
cargo fmt
Jan 17, 2023
5592aab
Added comment about missing PodBuilder function
Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
Copy link
Member

@adwk67 adwk67 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any changes in this PR that require rust 1.65? In the operator-templating changes that we did as preparation for the next release we stayed with 1.63, so it would be good to know if should move to 1.65 (and we should also change it in ubi8-rust-builder).

Copy link
Contributor Author

@fhennig fhennig Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @sbernauer about this and he told me that we already moved to 1.65 in the framework. I'm not 100% sure but I think the new framework version has a new clap version that requires at least 1.64.

Copy link
Member

@maltesander maltesander Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should come via templating and not be changed manually (it will fail to build if another templating PR is merged).
@adwk67 could we go for rust 1.65.0 or 1.66.1 in templating before the release?

Copy link
Member

@adwk67 adwk67 Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I suggest we go for 1.65. We can make that change before we roll out the templating changes across all operators on Thursday.

Copy link
Member

@sbernauer sbernauer Jan 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator-templating is already on 1.65 stackabletech/operator-templating@8d04aa2
This actually reduces the lag behind upstreaming templating.
IMHO go for it

override: true
- uses: Swatinem/rust-cache@6720f05bc48b77f96918929a9019fb2203ff71f8 # tag=v2.0.0
with:
Expand Down Expand Up @@ -150,7 +150,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
components: rustfmt
override: true
- uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # renovate: tag=v1.0.3
Expand All @@ -172,7 +172,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
components: clippy
override: true
- uses: Swatinem/rust-cache@6720f05bc48b77f96918929a9019fb2203ff71f8 # tag=v2.0.0
Expand Down Expand Up @@ -206,7 +206,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
components: rustfmt
override: true
- uses: Swatinem/rust-cache@6720f05bc48b77f96918929a9019fb2203ff71f8 # tag=v2.0.0
Expand Down Expand Up @@ -236,7 +236,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
override: true
- uses: Swatinem/rust-cache@6720f05bc48b77f96918929a9019fb2203ff71f8 # tag=v2.0.0
with:
Expand Down Expand Up @@ -307,7 +307,7 @@ jobs:
uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
override: true
- name: Set up rust-cache
uses: Swatinem/rust-cache@6720f05bc48b77f96918929a9019fb2203ff71f8 # tag=v2.0.0
Expand Down Expand Up @@ -372,7 +372,7 @@ jobs:
- uses: actions-rs/toolchain@16499b5e05bf2e26879000db0c1d13f7e13fa3af # renovate: tag=v1.0.7
with:
profile: minimal
toolchain: "1.63.0"
toolchain: "1.65.0"
components: rustfmt
override: true
- name: Install requirements for version tool
Expand Down
8 changes: 5 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,19 @@ All notable changes to this project will be documented in this file.

### Changed

- Fixed the RoleGroup `selector`. It was not used before. ([#401])
- Updated operator-rs to 0.30.1 ([#382], [#401])
- Updated operator-rs to 0.31.0 ([#382], [#401], [#408])
- Do not run init container as root anymore and avoid chmod and chown ([#390])
- [BREAKING] Use Product image selection instead of version. `spec.version` has been replaced by `spec.image` ([#394])
- [BREAKING]: Removed tools image (reporting task job and init container) and replaced with NiFi product image. This means the latest stackable version has to be used in the product image selection ([#397])
- Fixed the RoleGroup `selector`. It was not used before. ([#401])
- Refactoring of authentication handling ([#408])

[#401]: https://github.com/stackabletech/nifi-operator/pull/401
[#382]: https://github.com/stackabletech/nifi-operator/pull/382
[#390]: https://github.com/stackabletech/nifi-operator/pull/390
[#394]: https://github.com/stackabletech/nifi-operator/pull/394
[#397]: https://github.com/stackabletech/nifi-operator/pull/397
[#401]: https://github.com/stackabletech/nifi-operator/pull/401
[#408]: https://github.com/stackabletech/nifi-operator/pull/408

## [0.8.1] - 2022-11-10

Expand Down
79 changes: 43 additions & 36 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading