Skip to content

feat: Add DerbyConnection::jdbc_connection_details_for_network_access helper#1200

Merged
sbernauer merged 5 commits intomainfrom
feat/derby-host-part
Apr 24, 2026
Merged

feat: Add DerbyConnection::jdbc_connection_details_for_network_access helper#1200
sbernauer merged 5 commits intomainfrom
feat/derby-host-part

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Apr 23, 2026 •
edited
Loading

Description

Needed for stackabletech/druid-operator#814

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer changed the title feat: Add DerbyConnection::jdbc_connection_details_with_host_part helper feat: Add DerbyConnection::jdbc_connection_details_for_network_access helper Apr 24, 2026
@sbernauer sbernauer marked this pull request as ready for review April 24, 2026 11:50
@sbernauer sbernauer mentioned this pull request Apr 24, 2026
Open
22 tasks
@sbernauer sbernauer self-assigned this Apr 24, 2026
@sbernauer sbernauer requested a review from maltesander April 24, 2026 12:26
maltesander
maltesander approved these changes Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit adc92d4 Apr 24, 2026
5 checks passed
@sbernauer sbernauer deleted the feat/derby-host-part branch April 24, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @maltesander