Skip to content

chore!: Use serde_json::Value instead of String for user-provided JSON configOverrides#1206

Open
sbernauer wants to merge 2 commits intomainfrom
chore/json-config-overrides
Open

chore!: Use serde_json::Value instead of String for user-provided JSON configOverrides#1206
sbernauer wants to merge 2 commits intomainfrom
chore/json-config-overrides

Conversation

@sbernauer
Copy link
Copy Markdown
Member

Description

Feedback from stackabletech/opensearch-operator#137

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added

@sbernauer sbernauer self-assigned this May 7, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering May 7, 2026
@dervoeti dervoeti self-requested a review May 7, 2026 17:42
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 7, 2026
Copy link
Copy Markdown
Member

@dervoeti dervoeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


### Changed

- BREAKING: Use `serde_json::Value` instead of `String` for user-provided JSON configOverrides. This changed is marked as breaking, as it causes a breaking change to the CRD ([#1206]).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- BREAKING: Use `serde_json::Value` instead of `String` for user-provided JSON configOverrides. This changed is marked as breaking, as it causes a breaking change to the CRD ([#1206]).
- BREAKING: Use `serde_json::Value` instead of `String` for user-provided JSON configOverrides. This change is marked as breaking, as it causes a breaking change to the CRD ([#1206]).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants