Skip to content

[Merged by Bors] - Logging #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
siegfriedweber wants to merge 23 commits into from
Closed

[Merged by Bors] - Logging #517

siegfriedweber wants to merge 23 commits into from

Conversation

@siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Dec 8, 2022 •
edited by sbernauer
Loading

Description

Add modules for log aggregation

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable) - will be handled by dedicated Issue
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber requested a review from a team December 8, 2022 16:08
@siegfriedweber siegfriedweber self-assigned this Dec 8, 2022
@siegfriedweber siegfriedweber mentioned this pull request Dec 8, 2022
Closed
28 tasks
@sbernauer sbernauer self-assigned this Dec 9, 2022
sbernauer
sbernauer reviewed Dec 9, 2022
View reviewed changes
sbernauer
sbernauer approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ltgm. Please wait with merging until stackabletech/zookeeper-operator#588 is approved. There might pop things up that need to be changed here

sbernauer
sbernauer approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent changes LGTM, feel free to merge

@siegfriedweber
Copy link
Member Author

siegfriedweber commented Dec 16, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 16, 2022
@siegfriedweber
Logging (#517)
3ab1ee0 
## Description

Add modules for log aggregation
@bors
Copy link
Contributor

bors bot commented Dec 16, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Logging [Merged by Bors] - Logging Dec 16, 2022
@bors bors bot closed this Dec 16, 2022
@bors bors bot deleted the logging branch December 16, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@siegfriedweber siegfriedweber

@sbernauer sbernauer

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siegfriedweber @sbernauer