Skip to content

Conversation

@fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 19, 2022

Description

part of this ticket: stackabletech/issues#300

Renamed from: https://github.com/stackabletech/operator-rs/tree/feat/affinity_0.25

Description:

  • Adds new PodBuilder methods for node selection and pod affinity (Also with tests)

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
…ke using them from some contexts easier.

Signed-off-by: Sönke Liebau <soenke.liebau@stackable.tech>
@fhennig fhennig marked this pull request as ready for review December 19, 2022 11:10
@fhennig fhennig requested a review from maltesander December 19, 2022 11:10
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig
Copy link
Contributor Author

fhennig commented Dec 19, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 19, 2022
## Description

part of this ticket: stackabletech/issues#300

Renamed from: https://github.com/stackabletech/operator-rs/tree/feat/affinity_0.25

Description: 
- Adds new PodBuilder methods for node selection and pod affinity (Also with tests)



Co-authored-by: Felix Hennig <felix.hennig@stackable.tech>
Co-authored-by: Felix Hennig <fhennig@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 19, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Feature: pod builder affinity and node selection [Merged by Bors] - Feature: pod builder affinity and node selection Dec 19, 2022
@bors bors bot closed this Dec 19, 2022
@bors bors bot deleted the feature/pod-builder-affinity-and-node-selection branch December 19, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants