Skip to content

feat: Add TLS certificate util crate#736

Merged
Techassi merged 57 commits intomainfrom
feat/tls-cert-generation
Mar 15, 2024
Merged

feat: Add TLS certificate util crate#736
Techassi merged 57 commits intomainfrom
feat/tls-cert-generation

Conversation

@Techassi
Copy link
Copy Markdown
Member

@Techassi Techassi commented Feb 13, 2024 •
edited
Loading

Follow-up of #730, discussed in stackabletech/documentation#522, tracked by stackabletech/issues#361

This PR adds a crate which handles TLS certificate generation, reading and writing.

@Techassi Techassi self-assigned this Feb 13, 2024
This was referenced Feb 13, 2024
Merged
Closed
Closed
@Techassi
Copy link
Copy Markdown
Member Author

Techassi commented Feb 23, 2024

The basic work is mostly done, but a few pieces are still missing:

  • Add a manager, which contains one or more CAs, which will be rotated automatically once they expire.
  • Add dynamic TLS cert resolver in the webhook server

@Techassi
Copy link
Copy Markdown
Member Author

Techassi commented Mar 4, 2024 •
edited
Loading 

* Add a manager, which contains one or more CAs, which will be rotated automatically once they expire.
* Add dynamic TLS cert resolver in the webhook server

I decided to move this into a separate PR as this PR is already big enough. Both features can be implemented on top of the changes introduced in this PR.

Techassi and others added 2 commits March 4, 2024 14:32
@Techassi Techassi marked this pull request as ready for review March 4, 2024 13:35
@Techassi Techassi requested review from NickLarsenNZ and nightkr March 4, 2024 13:35
nightkr
nightkr reviewed Mar 12, 2024
View reviewed changes
Comment thread stackable-certs/src/lib.rs Outdated
Comment thread stackable-certs/src/lib.rs Outdated
Comment thread stackable-certs/src/keys/mod.rs Outdated
Comment thread src/commons/secret.rs Outdated
@Techassi Techassi requested a review from nightkr March 13, 2024 09:25
nightkr
nightkr reviewed Mar 13, 2024
View reviewed changes
Comment thread stackable-certs/src/keys/rsa.rs Outdated
Comment thread stackable-certs/src/keys/rsa.rs Outdated
Comment thread stackable-certs/src/keys/rsa.rs Outdated
Comment thread stackable-certs/src/keys/rsa.rs Outdated
@Techassi Techassi requested a review from nightkr March 14, 2024 09:17
NickLarsenNZ
NickLarsenNZ previously approved these changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. None of them should be blockers. Will let you decide whether to include them.

Comment thread stackable-certs/src/ca/mod.rs
Comment thread stackable-certs/src/ca/mod.rs Outdated
Comment thread stackable-certs/src/ca/mod.rs
Comment thread stackable-certs/src/ca/mod.rs Outdated
@Techassi Techassi enabled auto-merge March 15, 2024 10:30
NickLarsenNZ
NickLarsenNZ approved these changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Techassi Techassi added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit 8664a3d Mar 15, 2024
@Techassi Techassi deleted the feat/tls-cert-generation branch March 15, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

@nightkr nightkr Awaiting requested review from nightkr

Assignees

@Techassi Techassi

Labels

None yet

Projects

Stackable Engineering
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Techassi @nightkr @NickLarsenNZ