chore: implement PartialEq for most Snafu Error enums#757
Merged
NickLarsenNZ merged 6 commits intomainfrom Mar 26, 2024
Merged
Conversation
Techassi
requested changes
Mar 25, 2024
Member
Techassi
left a comment
There was a problem hiding this comment.
Looking good! Only requires a small change.
As already discussed, we might want to thrive to add more unit tests in the crates themself (where testing might be easier), instead of relying on external tests (in operators). It then might be possible to eliminate some of the manually implemented PartialEq implementations.
Co-authored-by: Techassi <git@techassi.dev>
Techassi
approved these changes
Mar 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change is to encourage testing error variants by type rather than text contents.
PartialEqon most Snafu Error enums.PartialEqfor Snafu error enums that use types that are not directly comparable.Important
Some variants are impossible to compare, so these implementations are restricted to
#[cfg(test)]because they cause panics.Definition of Done Checklist