Skip to content

test: Use long Secret name - #734

Merged
sbernauer merged 2 commits into
mainfrom
test/use-long-secret-name
Aug 5, 2026
Merged

test: Use long Secret name#734
sbernauer merged 2 commits into
mainfrom
test/use-long-secret-name

Conversation

@sbernauer

@sbernauer sbernauer commented Aug 5, 2026

Copy link
Copy Markdown
Member

Description

Doesn't fix a bug or anything, just increases the test variance

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

Doesn't fix a bug or anything, just increases the test variance
@sbernauer sbernauer self-assigned this Aug 5, 2026
@sbernauer sbernauer moved this to Development: Waiting for Review in Stackable Engineering Aug 5, 2026
@siegfriedweber
siegfriedweber self-requested a review August 5, 2026 07:31
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 5, 2026

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I just want to mention that this change does not test code in the secret operator because the Secret name is not read in the k8sSearch backend.

@sbernauer
sbernauer added this pull request to the merge queue Aug 5, 2026
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering Aug 5, 2026
Merged via the queue into main with commit 601960e Aug 5, 2026
12 checks passed
@sbernauer
sbernauer deleted the test/use-long-secret-name branch August 5, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants