Support listing endpoints of Listeners in "stacklet list" command#213
Conversation
| }; | ||
| for address in listener_status.ingress_addresses.iter().flatten() { | ||
| for port in &address.ports { | ||
| // Listener names usually have the pattern "listener-simple-hdfs-namenode-default-0" or |
There was a problem hiding this comment.
suggestion: We should make the naming consistent. Then we could add a stable function which extracts the raw display name.
There was a problem hiding this comment.
The problem is that the ListenerClass name is equal to the name of the PVC that creates it.
And the pvc naming is done by k8s based on the name of the Pod and the name of the volume in the PodSpec.
And it also differs depend on wether a persistent or ephemeral volume is used :/ So everything is a mess....
There was a problem hiding this comment.
Well, that's just... great. I guess we can make it stable(ish) sometime in the future. Is it still worth pulling the code out into its own function?
There was a problem hiding this comment.
Nice change, I like the addition of some test cases!
There was a problem hiding this comment.
Oh, huh. Guess I missed sending my reply here the other day (or GH ate it). I'd personally much rather just show the name as-is than mangle it like this. That would also make it easier/clearer for users to move between the "easy facade" of stackablectl and reading the backend data via kubectl when something goes wrong.
Co-authored-by: Techassi <git@techassi.dev>
|
What does this ticket fix? Only HDFS? Everything? |
Description
Currently shows
Definition of Done Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information