Skip to content

fix: Dont fail "stacklet list" on clusters without listener-operator#219

Merged
sbernauer merged 5 commits into
mainfrom
fix/no-listener-installed
Mar 14, 2024
Merged

fix: Dont fail "stacklet list" on clusters without listener-operator#219
sbernauer merged 5 commits into
mainfrom
fix/no-listener-installed

Conversation

@sbernauer
Copy link
Copy Markdown
Member

@sbernauer sbernauer commented Mar 13, 2024 •
edited
Loading

Description

Fixup of #213

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

sbernauer
sbernauer commented Mar 13, 2024
View reviewed changes
Comment thread rust/stackable-cockpit/src/platform/service.rs Outdated
Techassi
Techassi reviewed Mar 13, 2024
View reviewed changes
Comment thread rust/stackable-cockpit/src/platform/service.rs Outdated
Comment thread rust/stackable-cockpit/src/platform/service.rs Outdated
Comment thread rust/stackable-cockpit/src/platform/service.rs Outdated
@sbernauer sbernauer requested a review from Techassi March 13, 2024 13:36
@sbernauer sbernauer added this pull request to the merge queue Mar 14, 2024
Merged via the queue into main with commit 1d95a94 Mar 14, 2024
@sbernauer sbernauer deleted the fix/no-listener-installed branch March 14, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sbernauer @Techassi