Skip to content

[Merged by Bors] - switched to dev and added some timeouts - #338

Closed
fhennig wants to merge 3 commits into
mainfrom
fix/docs-test-nightly-to-dev
Closed

[Merged by Bors] - switched to dev and added some timeouts#338
fhennig wants to merge 3 commits into
mainfrom
fix/docs-test-nightly-to-dev

Conversation

@fhennig

@fhennig fhennig commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

Description

test: https://ci.stackable.tech/view/05%20Documentation%20Tests/job/superset-operator-documentation-test/6/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander
maltesander self-requested a review March 10, 2023 08:39

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread docs/modules/superset/examples/getting_started/getting_started.sh Outdated
Comment thread docs/modules/superset/examples/getting_started/getting_started.sh.j2 Outdated

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fhennig

fhennig commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

bors merge

@bors

bors Bot commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

Pull request successfully merged into main.

Build succeeded:

@bors bors Bot changed the title switched to dev and added some timeouts [Merged by Bors] - switched to dev and added some timeouts Mar 10, 2023
@bors bors Bot closed this Mar 10, 2023
@bors
bors Bot deleted the fix/docs-test-nightly-to-dev branch March 10, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants