[Merged by Bors] - Adapt discovery to best practice#131
Closed
maltesander wants to merge 13 commits intomainfrom
Closed
[Merged by Bors] - Adapt discovery to best practice#131maltesander wants to merge 13 commits intomainfrom
maltesander wants to merge 13 commits intomainfrom
Conversation
…d properties replaced via script.
razvan
reviewed
Feb 11, 2022
Member
razvan
left a comment
razvan
left a comment
There was a problem hiding this comment.
I wouldn't install os packages when setting up a Trino cluster because that can go wrong in many ways.
removed manually downloading dependencies (openssl)
Member
Yes! We should never assume that those machines have internet access! |
Member
Author
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
## Description fixes #119 - Discovery now works via setting env variable from config map - Improved the Trino MVP without HTTPS, Authentication, OPA etc. Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #119
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information