Skip to content

[Merged by Bors] - Adapt discovery to best practice #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maltesander wants to merge 13 commits into from
Closed

[Merged by Bors] - Adapt discovery to best practice #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4ff4faf
hive and opa configmaps now mounted as env variables for discovery an…
maltesander Feb 10, 2022
c3d4f19
trino now can be used insecurely via http or with authentication via …
maltesander Feb 10, 2022
68b9d8a
Adapted docs.
maltesander Feb 10, 2022
ee6e5e0
Merge remote-tracking branch 'origin/main' into adapt_discovery_to_be…
maltesander Feb 10, 2022
bdac0ba
Adapted CHANGELOG.md
maltesander Feb 10, 2022
61f1c99
fixed markdown length problem
maltesander Feb 10, 2022
7a1ddc6
fixed markdown problem #2
maltesander Feb 10, 2022
ed2d71f
improved doc highlighting
maltesander Feb 10, 2022
d7628a6
improved doc highlighting
maltesander Feb 10, 2022
d1433a0
extended docs.
maltesander Feb 10, 2022
e951b8b
improved docs.
maltesander Feb 10, 2022
ce521f3
using tools docker image for init container.
maltesander Feb 11, 2022
e91ff57
regenerated manifests.
maltesander Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,22 @@ All notable changes to this project will be documented in this file.

### Changed

- BREAKING: `ClusterRef` namespace now optional ([#95]).
- BREAKING: CRD changes. The `spec.opa` and `spec.hive` renamed to
`spec.opaConfigMapName` and `spec.hiveConfigMapName`
which only accept a String ([#131]).
- BREAKING: In case the namespace is omitted, the operator defaults to the `TrinoCluster` namespace instead of `default` ([#95]).
- User authentication now provided via secret instead of custom resource ([#81]).
- User authentication not exposed in configmap anymore ([#81]).
- TLS certificates / keystore now retrieved via secret-operator ([#81]).
- The Trino version is now a string instead of enum ([#81]).
- `operator-rs` `0.4.0` → `0.10.0` ([#81], [#95], [#118]).
- `stackable-regorule-crd` `0.2.0` → `0.6.0` ([#81], [#118]).
- Improvements to setting up (easy) insecure clusters ([#131])

[#81]: https://github.com/stackabletech/trino-operator/pull/81
[#95]: https://github.com/stackabletech/trino-operator/pull/95
[#118]: https://github.com/stackabletech/trino-operator/pull/118
[#131]: https://github.com/stackabletech/trino-operator/pull/131

## [0.2.0] - 2021-12-06

Expand Down
2 changes: 1 addition & 1 deletion deploy/config-spec/properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ properties:
value: "8443"
roles:
- name: "coordinator"
required: true
required: false
asOfVersion: "0.0.0"

- property: &queryMaxMemory
Expand Down
30 changes: 4 additions & 26 deletions deploy/crd/trinocluster.crd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,36 +199,14 @@ spec:
required:
- roleGroups
type: object
hive:
hiveConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
nodeEnvironment:
type: string
opa:
opaConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
s3:
description: Contains all the required connection information for S3.
nullable: true
Expand Down
2 changes: 1 addition & 1 deletion deploy/helm/trino-operator/configs/properties.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ properties:
value: "8443"
roles:
- name: "coordinator"
required: true
required: false
asOfVersion: "0.0.0"

- property: &queryMaxMemory
Expand Down
30 changes: 4 additions & 26 deletions deploy/helm/trino-operator/crds/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,36 +201,14 @@ spec:
required:
- roleGroups
type: object
hive:
hiveConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
nodeEnvironment:
type: string
opa:
opaConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
s3:
description: Contains all the required connection information for S3.
nullable: true
Expand Down
2 changes: 1 addition & 1 deletion deploy/manifests/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ data:
\ file: \"config.properties\"\n datatype:\n type: \"integer\"\n
\ min: \"1024\"\n max: \"65535\"\n defaultValues:\n - fromVersion:
\"0.0.0\"\n value: \"8443\"\n roles:\n - name: \"coordinator\"\n
\ required: true\n asOfVersion: \"0.0.0\"\n\n - property: &queryMaxMemory\n
\ required: false\n asOfVersion: \"0.0.0\"\n\n - property: &queryMaxMemory\n
\ propertyNames:\n - name: \"query.max-memory\"\n kind:\n type:
\"file\"\n file: \"config.properties\"\n datatype:\n type:
\"string\"\n unit: *unitMemory\n defaultValues:\n - fromVersion:
Expand Down
30 changes: 4 additions & 26 deletions deploy/manifests/crds.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,36 +203,14 @@ spec:
required:
- roleGroups
type: object
hive:
hiveConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
nodeEnvironment:
type: string
opa:
opaConfigMapName:
nullable: true
properties:
chroot:
nullable: true
type: string
name:
type: string
namespace:
nullable: true
type: string
required:
- name
type: object
type: string
s3:
description: Contains all the required connection information for S3.
nullable: true
Expand Down
2 changes: 2 additions & 0 deletions docs/modules/ROOT/pages/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ The Stackable Operator for Trino currently supports the following versions of Tr

include::partial$supported-versions.adoc[]

== Get Docker image

[source]
----
docker pull docker.stackable.tech/stackable/trino:<version>
Expand Down
Loading