Merged
Conversation
sbernauer
commented
Aug 17, 2023
b024675 to
62341d7
Compare
maltesander
reviewed
Aug 17, 2023
Member
maltesander
left a comment
There was a problem hiding this comment.
Just spelling. Maybe we should include our 24h default certificate rotation that kills everything anyways :)?
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Member
Author
|
@maltesander ready for another round of review |
Member
Author
maltesander
previously approved these changes
Aug 17, 2023
Member
maltesander
left a comment
There was a problem hiding this comment.
Minor things. LGTM otherwise if operator-rs is released!
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
3867cfe to
b426652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #429
Definition of Done Checklist