Skip to content

refactor: Change graceful shutdown timeout to string#463

Merged
sbernauer merged 7 commits intomainfrom
graceful-shutdown-timeout
Aug 25, 2023
Merged

refactor: Change graceful shutdown timeout to string#463
sbernauer merged 7 commits intomainfrom
graceful-shutdown-timeout

Conversation

@sbernauer
Copy link
Member

@sbernauer sbernauer commented Aug 25, 2023

Description

Part of #461
As discussed in Arc meeting on 2023-08-23

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [x] Changes are OpenShift compatible
- [x] CRD changes approved
- [x] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [x] Proper release label has been added

@sbernauer sbernauer force-pushed the graceful-shutdown-timeout branch from 9df4e14 to aa1d64a Compare August 25, 2023 06:05
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sbernauer sbernauer added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit e3684df Aug 25, 2023
@sbernauer sbernauer deleted the graceful-shutdown-timeout branch August 25, 2023 07:15
@lfrancke
Copy link
Member

This changes the CRD? Do we need anything in the docs, release notes etc.?

@lfrancke
Copy link
Member

lfrancke commented Sep 5, 2023

ping @maltesander in the absence of @sbernauer

@maltesander
Copy link
Member

Yes it changes the CRD slightly.
graceful_shutdown_seconds was renamed to graceful_shutdown_timeout and takes a duration (string like 1m) instead of an integer of seconds.
This was not released yet as far as i remember and is just another optional field added. So no breaking changes i would say.
But i think its not reflected in the docs https://github.com/stackabletech/trino-operator/blob/main/docs/modules/trino/pages/usage_guide/operations/graceful-shutdown.adoc properly.

@lfrancke
Copy link
Member

Can you link the PR where you fixed the docs?

@maltesander
Copy link
Member

Sure thing! #466

@lfrancke lfrancke added the release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/23.11.0 release-note/action-required Denotes a PR that introduces potentially breaking changes that require user action.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants