chore(release): Set up semantic-release #49
Conversation
|
PS: We need to push all workflow files to the |
JoseLion
force-pushed
the
chore/setup-semantic-release
branch
from
6154bc8 to
6db59bd
Compare
|
Result of testing the |
JoseLion
force-pushed
the
chore/setup-semantic-release
branch
from
6db59bd to
6852bfc
Compare
JoseLion
force-pushed
the
chore/setup-semantic-release
branch
from
6852bfc to
27abf80
Compare
.github/workflows/pages.yml
Outdated
| steps: | ||
| - name: Deploy to GitHub Pages | ||
| - uses: actions/deploy-pages@v1 | ||
| id: deployment |
There was a problem hiding this comment.
@JoseLion since you are not referencing this step anywhere, I think you should be able to get rid of the id
There was a problem hiding this comment.
Thanks, I'll give it a try! I took this from GitHub's auto-generated action for deploying GH Pages, so I'm not sure why they added the id to that final step 🤔
There was a problem hiding this comment.
I worked perfectly fine! Thank you @sestrella!! 🙂
.github/workflows/release.yml
Outdated
| branch: release | ||
| dry_run: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} |
There was a problem hiding this comment.
@JoseLion what do you think about renaming GH_TOKEN secret to GITHUB_TOKEN just for the sake of consistency?
There was a problem hiding this comment.
I tried that, but unfortunately, GitHub does not allow to create secrets starting with GITHUB_. I think they reserve that prefix for their own use 🙂
There was a problem hiding this comment.
@JoseLion oh! I realized this is a secret declared by us, most likely it is bound to your GH user account. I think it would be better to use the token already provided by the execution context, so try getting rid of GH_TOKEN and change this reference to secrets.GITHUB_TOKEN GH actions create one token by default
There was a problem hiding this comment.
If you face some issues with permissions using this token try assigning a different permission set
There was a problem hiding this comment.
Yep, the problem was around permission. Awesome, I'll do that instead 👍🏼
There was a problem hiding this comment.
It seems to be working on dry-mode. I'll keep the GH_TOKEN secret around just in case until our first release. Thanks for the help @sestrella! 🎉
JoseLion
force-pushed
the
chore/setup-semantic-release
branch
from
e76d369 to
da162f1
Compare
JoseLion
force-pushed
the
chore/setup-semantic-release
branch
from
6541f08 to
0bdad85
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR sets up semantic-release and adds a workflow to GitHub Actions to release a package to NPM whenever changes are pushed to the
releasebranch