Skip to content

Conversation

@JoseLion
Copy link
Contributor

@JoseLion JoseLion commented Sep 5, 2022

This PR fixes some export issues in the entry point of the library:

  • Re-export TypeFactories and its types to make clearer the exposure on the API
  • Remove the default export of expect. Now the library exports more than just the expect function in its entry point, so it doesn't make sense to make expect the default. Will add the default export again if it makes sense or if we get feedback in the future

@JoseLion JoseLion requested a review from byrpatrick September 5, 2022 18:56
@JoseLion JoseLion self-assigned this Sep 5, 2022
Copy link
Member

@byrpatrick byrpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 🚀

@JoseLion JoseLion merged commit 5d84a9e into main Sep 6, 2022
@JoseLion JoseLion deleted the fix/index-exports branch September 6, 2022 14:52
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants