Skip to content

add systemd-resolved configuration feature#51

Merged
g0rgamesh merged 8 commits into
mainfrom
feature/systemd-resolved
Jul 17, 2026
Merged

add systemd-resolved configuration feature#51
g0rgamesh merged 8 commits into
mainfrom
feature/systemd-resolved

Conversation

@g0rgamesh

Copy link
Copy Markdown
Contributor

No description provided.

@g0rgamesh
g0rgamesh requested a review from a team as a code owner July 16, 2026 12:07

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the systemd-resolved configuration by introducing a block that conditionally enables the service, creates a configuration directory, deploys a DNS configuration template, and restarts the service. Feedback on these changes includes ensuring idempotency by conditionally restarting systemd-resolved only when the template configuration changes (and using the FQCN for the template module), as well as guarding the resolv_nameservers variable in the template with an is defined check to prevent execution failures when the variable is not provided.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread roles/systemd_networkd/tasks/main.yml Outdated
Comment thread roles/systemd_networkd/templates/dns_config.j2 Outdated
Comment thread roles/systemd_networkd/tasks/main.yml Outdated
@g0rgamesh
g0rgamesh requested a review from mgrzybek July 17, 2026 08:33
mgrzybek
mgrzybek previously approved these changes Jul 17, 2026
Comment thread roles/systemd_networkd/templates/dns_config.j2
Comment thread roles/systemd_networkd/templates/dns_config.j2 Outdated
Comment thread roles/systemd_networkd/templates/dns_config.j2 Outdated
@g0rgamesh
g0rgamesh merged commit a3d73e6 into main Jul 17, 2026
4 checks passed
@g0rgamesh
g0rgamesh deleted the feature/systemd-resolved branch July 17, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants