Synchronise 2025.1 with upstream#274
Merged
Merged
Conversation
The empty-MAC guard in _get_port_ip4_ips_and_ip6_flag returns [] instead of the expected (list, bool) tuple. This would cause a crash if a port with an empty MAC column were encountered during datapath provisioning. Fix the return value to ([], False). Conflicts: neutron/agent/ovn/metadata/agent.py Closes-Bug: #2150543 Assisted-By: Claude Opus 4.6 Change-Id: Idc7d789ffe0289bf28fb289456196c307dd4a706 Signed-off-by: Eduardo Olivares <eolivare@redhat.com> (cherry picked from commit 6f529d9) (cherry picked from commit bd4fa33)
Neutron's Designate external DNS driver does not pass edit_managed=True when constructing the admin designateclient. When a floating IP has associated managed DNS records in Designate, deleting the floating IP fails with HTTP 500 because Designate rejects the deletion with "Managed records may not be deleted". Pass edit_managed=True only to the admin_client, which has admin credentials and passes Designate's edit_managed_records policy check. The regular user client must not set this flag because Designate requires SYSTEM_ADMIN role for it. For forward DNS deletion of managed records, fall back to admin_client when the user client gets a BadRequest from Designate. Closes-Bug: #2149807 Assisted-By: Claude Code 4.6 Opus Change-Id: Iedf0f26708560fe063a71925d5d39542ca181154 Signed-off-by: Omer <oschwart@redhat.com> (cherry picked from commit 44d061a)
github-actions
Bot
added
the
automated
github-actions
Bot
added
synchronisation
automated
priteau
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2025.1 from upstream stable/2025.1.